Split storage sync P2P protocol (manual fallback)#6277
Merged
martintomazic merged 5 commits intomasterfrom Aug 7, 2025
Merged
Conversation
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
martintomazic
force-pushed
the
martin/feature/split-storagesync-p2p-v2
branch
3 times, most recently
from
7461171 to
a234758
Compare
martintomazic
commented
Jul 24, 2025
martintomazic
commented
Jul 24, 2025
martintomazic
force-pushed
the
martin/feature/split-storagesync-p2p-v2
branch
from
a234758 to
036756f
Compare
martintomazic
requested review from
kostko,
peterjgilbert,
peternose,
pro-wh and
ptrus
as code owners
peternose
reviewed
Jul 30, 2025
martintomazic
force-pushed
the
martin/feature/split-storagesync-p2p-v2
branch
2 times, most recently
from
8cf69e6 to
6b30fe1
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #6277 +/- ##
==========================================
+ Coverage 64.62% 64.70% +0.08%
==========================================
Files 690 696 +6
Lines 67593 67803 +210
==========================================
+ Hits 43680 43870 +190
- Misses 18855 18880 +25
+ Partials 5058 5053 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
martintomazic
force-pushed
the
martin/feature/split-storagesync-p2p-v2
branch
from
6b30fe1 to
27cfc64
Compare
martintomazic
force-pushed
the
martin/feature/split-storagesync-p2p-v2
branch
3 times, most recently
from
48d10af to
aac7046
Compare
Legacy storage sync protocol is still advertised and served to enable seamless rolling upgrades of the network.
martintomazic
force-pushed
the
martin/feature/split-storagesync-p2p-v2
branch
from
aac7046 to
c02ca0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #6262 it might be simpler to manually handle fallback to the legacy protocol.
Closes #5751.
Regarding the style, I would prefer to keep it consistent with other p2p packages even if not optimal: #6262 (comment)